return sendResponse didn't hit content script to perform callback - happening only for a particular site

Fixed Issue #20382015

Details

Created
Jan 31, 2019
Privacy
This issue is public.
Found in build #
44.17763
Fixed in build #
18.18834
Reports
Reported by 1 person

Sign in to watch or report this issue.

Steps to reproduce

Check-in Instructions

SEE pull request:  

https://microsoft.visualstudio.com/_git/os/pullrequest/2791546?_a=overview 

commit: 

https://microsoft.visualstudio.com/OS/_git/7bc5fd9f-6098-479a-a87e-1533d288d438/commit/6228c58365ebf73c0f7c33fc087bf4ddabaa02de

Conflict Contact

AgarAnk, +91-9100954270

Submitted by

AgarAnk

What is the issue?

runtime.onMessage is not sending the response to content script for https://cloudconnect2.norton.com/cloudconnect/home?X-Symc-User-Agent=IDSafe/6.2.1.6/XBrowser/6.2.1.6/CC/1.0&newSession=true. The sendResponse will be broken in any website that does a anchor navigation post page load.

How was the issue/bug found?

This bug was reported by Symantec developer - 
vivek subramanianvivek_subramanian@symantec.com 
and is publicly viewable a

https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/19974288/

Quantify the impact of the issue - why do we need to service this issue now?

Norton Symantec extension is broken in RS5 builds. This has lead to Norton’s paid extension stopped working in RS5 builds.

Is the fix ready and what is it?

The fix is ready.

The CAssistantManager::Navigated(DWORD newMarkupId) is getting called for navigation to a local anchor on the same page. When this happens, the _bhxContentTiming being set to BhxContentTimingDocumentNone post which event listener response is not fired thinking of it’s as a navigation to a new page.

How was the fix Validated?

All scenarios were validated manually and also buddy tested by utkpat.
Added a new DRT (webdriver.bhx-runtime-onMessage.html) where the webpage performs anchor navigation to guard from future regressions.

Regression risk level of the fix

Low.

19H1 flight number + Date it went 
 
out​

The fix was checked into an 19h1 branch on 2nd Feb 2018. 18332.1.19h1_release.190201-1428

Do you have any data points that can be monitored to ensure that the fix works or if there are adverse effects from the fix?

The fix was verified to work via an internal flight and no regressions were found.

Does this fix need to be backported to TH2, RS1, RS2, RS3 or prior releases (for SAC/LTSB customers)?

RS5 only

QD signing off on this change

ImranS

How to validate/test for regressions

(required for WSD pre-release validation

Scenario to validate
:

  1. Open Edge Browser 

  2. Load the extension (zip file attached in this ticket).

  3. After extension loaded, open new tab/use existing tab in edge browser.

  4. Put this URL in the address bar - https://cloudconnect2.norton.com/cloudconnect/home?X-Symc-User-Agent=IDSafe/6.2.1.6/XBrowser/6.2.1.6/CC/1.0&newSession=true

  5. Right click on center of screen, open Inspect Element.

  6. Go to “Console”

  7. Clear all logs messages (if it’s already available)

  8. Once cleared, perform this below java script code

  9. "window.postMessage({}, “*”)

When you perform 9th step, the expected log messages from the extension,

Expected Result :

MessageListener SendMessage Executed

Hey, this is the response message!

Is this Product regression or Servicing regression?

Please provide bug that caused the regression.

Product Regression

This is a regression which got introduced by Pull Request 1985207: Fixed Injecting Script and Stylesheet Fails After Navigation Is Cancelled

 Release Note

 
Not needed.

  1. Open Edge Browser (44.17763.1.0)

  2. Load the extension (zip file attached in this ticket).

  3. After extension loaded, open new tab/use existing tab in edge browser.

  4. Put this URL in the address bar - https://cloudconnect2.norton.com/cloudconnect/home?X-Symc-User-Agent=IDSafe/6.2.1.6/XBrowser/6.2.1.6/CC/1.0&newSession=true

  5. Right click on center of screen, open Inspect Element.

  6. Go to “Console”

  7. Clear all logs messages (if it’s already available)

  8. Once cleared, perform this below java script code

  9. "window.postMessage({}, “*”)

When you perform 9th step, the expected log messages from the extension,

Expected Result,
MessageListener SendMessage Executed
Hey, this is the response message!

Actual Result,
MessageListener SendMessage Executed

Note:

  1. Open a new tab, go for google/facebook.com or any other live url.
  2. open Inspect Element and Console.
  3. perform javascript code “window.postMessage({},"*”)
  4. Expected results come.

Why is it happening for "https://cloudconnect2.norton.com/cloudconnect/home?X-Symc-User-Agent=IDSafe/6.2.1.6/XBrowser/6.2.1.6/CC/1.0&newSession=true"this alone?

Attachments

Comments and activity

  • Microsoft Edge Team

    Changed Assigned To to “Mahesh J.”

    Changed Steps to Reproduce

    Changed Status to “In code review”

    Changed Assigned To from “Mahesh J.” to “Scott W.”

    Changed Status from “In code review” to “Fixed”

    Changed Assigned To from “Scott W.” to “Ankit K.”

  • Hi!


    This issue has been resolved as "Fixed". This means that a fix will be pushed in a future update of Microsoft Edge. Please ensure you are installing Windows Updates so that you can receive this fix when it is pushed.​

    Thanks,​
    Zach

You need to sign in to your Microsoft account to add a comment.

Sign in